This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: request for blanket commit privs to *win32*


Adam Megacz wrote:

>http://gcc.gnu.org/ml/java-patches/2002-q1/msg00214.html
>
>   Basically, "unsigned jint" doesn't work, so I suggest using
>   uint<foo>_t (from stdint.h, part of the C99 standard) in shs.cc. I'd
>   like to know if this is acceptable, and if not, what I should use
>   instead.
>

The uint*_t is probibly fairly universal, but I'm not so sure about 
stdint.h. In SunOS 5.5 they are in <inttypes.h>, so it might be wise to 
at least wrap the include with a HAVE_STDINT_H or something. I guess if 
anyone wants to build libjava on such a platform they can figure out 
what to do and send us a patch.

Darwin has about the crapiest headers of any "current" unix, so if it 
works there then its probibly going to work on most targets!

>To make things move more quickly, may I please have permission to
>commit to the following files without waiting for review?
>
>  libjava/win32.cc
>  libjava/win32-threads.cc
>  libjava/include/win32-threads.h
>  libjava/include/win32-signals.h
>  libjava/java/*/*Win32*
>
>I'll still post my patches, I'd just like to be able to commit them
>without having to wait a week and repost a few times.
>

Yes, I have no objection to that.

regards

Bryce.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]