This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Final (TCP) socket timeout patch?
- From: Bryce McKinlay <bryce at waitaki dot otago dot ac dot nz>
- To: Nic Ferrier <nferrier at tf1 dot tapsellferrier dot co dot uk>
- Cc: java-patches at gcc dot gnu dot org
- Date: Sat, 05 Jan 2002 13:28:36 +1300
- Subject: Re: Final (TCP) socket timeout patch?
- References: <87zo3vw098.fsf_-_@tf1.tapsellferrier.co.uk>
Nic Ferrier wrote:
>Here is my last socket timeout patch (I hope).
>
>Please tell me that you think this is ok. If not I may have a pychotic
>episode.
>
This is fine apart from some minor lingering formatting nits. Please
check in the patch after fixing them. There is no need to resubmit the
patch. Thanks!
>+ /** A cached copy of the in stream for reading from the socket.
>+ */
> private InputStream in;
>
These comments might as well be one-liners, ie the "*/" on the same line.
>
>+ if(in == null)
>+ in = new SocketInputStream();
>
Need a space after "if"...
>+ return(jint) num;
>+#else
>+ throw new java::io::IOException (JvNewStringUTF ("unimplemented"));
>+#endif
>+ }
>+
>
... and "return".
regards
Bryce.