Re: Patch: FYI: loading a class twice

[minyard at acm dot org]

Tom Tromey <tromey@redhat.com> writes:

> I'm checking this in.  This is a reworked version of a patch from
> Corey Minyard.  I changed his patch to throw an error instead of
> printing a message to stderr.  This seems more correct to me.

Won't throwing an exception leave the system in a "half-baked" state?
That might not be good.  I agree that printing the message is not
optimal, but it might be better to pre-check the whole thing and
refuse the whole object if you find a problem.  I hadn't really
thought about it until now (it was just a quick hack), but it might be
better to go up a level, grab a lock, and do a scan for problems then
install all the classes.

-Corey