This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: core protocol take 2
- To: green at cygnus dot com
- Subject: Re: Patch: core protocol take 2
- From: Tom Tromey <tromey at redhat dot com>
- Date: 03 Sep 2001 15:44:17 -0600
- Cc: java-patches at gcc dot gnu dot org
- References: <200109032123.OAA22730@fencer.cygnus.com>
- Reply-To: tromey at redhat dot com
>>>>> "Anthony" == Anthony Green <green@redhat.com> writes:
Anthony> I've made some of Per's suggested changes, fixed a bug with
Anthony> how core_chain nodes were being allocated, and removed some
Anthony> debugging output.
Overall this looks good to me.
I have two questions/comments.
Anthony> +static core_chain *root;
Should references to this be synchronized?
Anthony> + else if (protocol.equals ("core"))
Anthony> + {
Anthony> + handler = new gnu.gcj.protocol.core.Handler ();
Anthony> + }
Is this code really needed?
I think we can just access the core handler via the Class.forName code
after this `if' -- that is, only the file handler needs a special
case.
Tom