Re: Patch: java class registration via .jcr section

["Anthony Green" <green at redhat dot com>]

> On Fri, Aug 03, 2001 at 11:05:02PM -0400, green@peach.cygnus.co.uk wrote:
> > +asm (JCR_SECTION_ASM_OP); /* cc1 doesn't know that we are switching! */
> > +STATIC void *__JCR_LIST__[1] __attribute__ ((__unused__)) = { 0 };
>
> Didn't I tell you not to do this?  This should be

Yes, you did - but you're replying to original email again :-)

My response to your comments had the subject: "Patch: java class
registration via .jcr section, take 2":
http://gcc.gnu.org/ml/gcc-patches/2001-08/msg00250.html

In any case, this note contains more new suggestions, so you can just ignore
"take 2" 'til "take 3" arrives...

> No, you don't need this.  Just use named_section.

Ok - I'll change this.

> > +#ifdef ASM_OUTPUT_JCR
> > +  ASM_OUTPUT_JCR (asm_out_file, name);
> > +#else
>
> Why on God's green earth are you adding yet another way to
> output a label?  This should be

All of this was modelled after the existing ASM_OUTPUT_* bits.  I'll make
your suggested changes.

> Further, let's avoid as much conditional compilation as possible
> by testing targetm.have_named_sections rather than JCR_SECTION_NAME.

Ok - thanks.    New patch on it's way....

AG