This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: java class registration via .jcr section, take 2
- To: green at peach dot cygnus dot co dot uk
- Subject: Re: Patch: java class registration via .jcr section, take 2
- From: Jeff Sturm <jsturm at one-point dot com>
- Date: Sun, 5 Aug 2001 12:24:25 -0400 (EDT)
- cc: gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org
On Sun, 5 Aug 2001 green@peach.cygnus.co.uk wrote:
> Thanks for catching those things Richard. They're fixed in this patch.
> Alex has approved the minor java bits.
FWIW I think this is a great idea. Two comments related to this patch:
1) Consider marking the class objects .protected so they can't be
overridden. This also prevents expensive symbol lookups at load time.
2) If a hash value could be stored in JCR_SECTION along with the class
pointer, we could possibly avoid referencing class data at startup. That
may only be a win for static linking though, and I'm not sure the
size tradeoff is worthwhile.
> + The preferred mechanism is through the .jcr section, which contain
> + a list of pointers to classes which get registered during
> + constructor invoction time. The fallback mechanism is to generate
^^^^^^^^^
Typo.
Jeff