This is the mail archive of the
java-patches@sourceware.cygnus.com
mailing list for the Java project.
Re: [patch] java.net: set SO_REUSEADDR on bind, -and- fix PR java.net/57
- To: Bryce McKinlay <bryce at albatross dot co dot nz>
- Subject: Re: [patch] java.net: set SO_REUSEADDR on bind, -and- fix PR java.net/57
- From: Warren Levy <warrenl at cygnus dot com>
- Date: Mon, 22 Nov 1999 23:31:53 -0800 (PST)
- cc: java-patches at sourceware dot cygnus dot com
On Tue, 23 Nov 1999, Bryce McKinlay wrote:
> PlainSocketImpl should be setting the SO_REUSEADDR socket option on calls to
> bind. This permits servers to re-use ports that are in the TIME_WAIT state.
Excellent! I had observed the problematic behavior before, but didn't
understand the cause until just now.
> While I was in there I fixed PR #57 too, which was probibly my fault.
Thanks, though you're being generous as I believe I'm the culprit on this
one.
> 1999-11-23 Bryce McKinlay <bryce@albatross.co.nz>
>
> * java/net/natPlainSocketImpl.cc: Fix potential buffer overruns in
> Exception messages.
> (bind): set SO_REUSEADDR before bind.
> * java/net/natPlainDatagramSocketImpl.cc: Fix potential buffer
> overruns.
One minor nit, could you please add "Fixes Java PR java.net/57" to your
buffer overflow ChangeLog entries for these 2 files (we're trying to record
the GNATS info).
Thanks again!
--warrenl