This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Wrong GCC PR2020 annotated for "[committed, libgomp,amdgcn] Fix plugin-gcn.c bug"

From: Andrew Stubbs <ams at codesourcery dot com>
To: Joseph Myers <joseph at codesourcery dot com>, "Richard Earnshaw (lists)" <Richard dot Earnshaw at arm dot com>
Cc: Jakub Jelinek <jakub at redhat dot com>, Thomas Schwinge <thomas at codesourcery dot com>, <gcc at gcc dot gnu dot org>
Date: Thu, 23 Jan 2020 16:57:29 +0000
Subject: Re: Wrong GCC PR2020 annotated for "[committed, libgomp,amdgcn] Fix plugin-gcn.c bug"
Ironport-sdr: V5EjLTq1gp4gX5zWqRdQEsSpd9qGv/4Oo0SZ3oOKaNzjdoB3squIYnH0X2p5oh1usnf1ThiW5P U5vojngHnF/JAOkZPfdt/QRS1qiCPxCOcnxAAsvbhMYCm/M+G/31ncdkBxLenI9V1br036OCVg uTG0g4004mXhapjWUJFJBQ/lMX7BPpDgVgREgoN5hKC6GSUAFyuPIxR93vZ3DcEiWsTXGXE5m/ +ip3coOfMQJ3ZV8AeE9WciaMKd4k47xl1nfzUKZOc7vwLFVY1BQ8u00fMSJ4sc6cdZpW+S2cwQ P40=
Ironport-sdr: 3B2FgdSAsh172rTg9Zv+XEWxzhCLp8mEoy83kInQFzizGjKgyGnNV4yozFvP5psZ/HIbJugjFo 28O16QpCApYg==
References: <b4733c3a-7555-816d-9290-18a8bad1e52b@codesourcery.com> <87blqutcx6.fsf@euler.schwinge.homeip.net> <20200123152843.GA10088@tucnak> <6d890e3c-781d-70d4-ab9b-028c294df6e4@arm.com> <alpine.DEB.2.21.2001231643280.22671@digraph.polyomino.org.uk>

On 23/01/2020 16:46, Joseph Myers wrote:

On Thu, 23 Jan 2020, Richard Earnshaw (lists) wrote:

Perhaps we should restrict that to a single line, ie only horizontal white
space.  Our commit style isn't really that free-form when citing bugs.  Or
perhaps require [:.]?\w after the number (ie an optional period or colon and
then some white space).


I presume it's intended to handle a paragraph where the reference to bug
2020 happens to have a line break in the middle of it.

This is code maintained by overseers
(/sourceware/infra/bin/email-to-bugzilla, version-controlled in CVS,
shared by all sourceware projects) which hasn't changed since 2014.  The
only GCC-specific piece is a very thin wrapper
(~gccadmin/hooks-bin/email-to-bugzilla-filtered) based on that used by
binutils-gdb.

Indeed, PR2019 has a number of unrelated commits referenced, and pr2018has one too. The years before that appear to have escaped the problem.


Andrew

Follow-Ups:
- Re: Wrong GCC PR2020 annotated for "[committed, libgomp,amdgcn] Fix plugin-gcn.c bug"
  - From: Jonathan Wakely

References:
- Wrong GCC PR2020 annotated for "[committed, libgomp,amdgcn] Fix plugin-gcn.c bug"
  - From: Thomas Schwinge
- Re: Wrong GCC PR2020 annotated for "[committed, libgomp,amdgcn] Fix plugin-gcn.c bug"
  - From: Jakub Jelinek
- Re: Wrong GCC PR2020 annotated for "[committed, libgomp,amdgcn] Fix plugin-gcn.c bug"
  - From: Richard Earnshaw (lists)
- Re: Wrong GCC PR2020 annotated for "[committed, libgomp,amdgcn] Fix plugin-gcn.c bug"
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]