This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: git: remote: *** The first line of a commit message should be a short description of the change, not a single word.


On 1/21/20 11:38 AM, Richard Earnshaw (lists) wrote:
On 21/01/2020 16:14, Jonathan Wakely wrote:
On Tue, 21 Jan 2020 at 16:03, Martin Liška <mliska@suse.cz> wrote:

Can you please remove the hook for user branches likes:

$ git push origin me/filter-non-common
Enumerating objects: 27, done.
Counting objects: 100% (27/27), done.
Delta compression using up to 16 threads
Compressing objects: 100% (14/14), done.
Writing objects: 100% (14/14), 1.77 KiB | 1.77 MiB/s, done.
Total 14 (delta 13), reused 0 (delta 0)
remote: *** The first line of a commit message should be a short description of the change, not a single word. remote: error: hook declined to update refs/users/marxin/heads/filter-non-common
To git+ssh://gcc.gnu.org/git/gcc.git
   ! [remote rejected]         me/filter-non-common -> refs/users/marxin/heads/filter-non-common (hook declined)
error: failed to push some refs to 'git+ssh://gcc.gnu.org/git/gcc.git'


Requiring slightly better messages than just a single word doesn't
seem to restrictive to me, even on user branches.

plus it teaches you good practice in a safe area.

I agree.  What's more, if you ever want to merge the branch into trunk you'll need to fix such messages, so why not just get them right in the first place?

Are you using 'merge' with some meaning other than git merge? because merging to trunk is verboeten.

nathan

--
Nathan Sidwell


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]