This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: basic_block flags, BB_VISITED

From: Bernd Schmidt <bschmidt at redhat dot com>
To: Richard Biener <richard dot guenther at gmail dot com>
Cc: Thomas Schwinge <thomas at codesourcery dot com>, GCC Development <gcc at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>, kugan dot vivekanandarajah at linaro dot org, Nathan Sidwell <nathan at acm dot org>
Date: Fri, 14 Oct 2016 12:57:31 +0200
Subject: Re: basic_block flags, BB_VISITED
Authentication-results: sourceware.org; auth=none
References: <8760ov2wbg.fsf@hertz.schwinge.homeip.net> <6175ee3b-74d4-0f29-c9ff-163c201d1f8d@redhat.com> <CAFiYyc25xScCu0s2LYDe9t-oLfa0KbFg8y_tpVzqB0k3EJBnow@mail.gmail.com>

On 10/14/2016 11:26 AM, Richard Biener wrote:

On Fri, Oct 14, 2016 at 11:15 AM, Bernd Schmidt <bschmidt@redhat.com> wrote:

So maybe it should just call clear_bb_flags instead of doing the loop
itself? Ok if that works.


That doesn't generally work, it clears too many flags (it was appearantly
designed for RTL).

Or maybe it could be argued that more tree-specific flags ought to be inBB_FLAGS_TO_PRESERVE, or that it would make more sense to define a morespecific BB_FLAGS_TO_KEEP.

So maybe just change the loop at the end of evrp, it clearly wants toclean up after itself so just make it do it reliably.



Bernd

Follow-Ups:
- Re: basic_block flags, BB_VISITED
  - From: Richard Biener

References:
- basic_block flags, BB_VISITED
  - From: Thomas Schwinge
- Re: basic_block flags, BB_VISITED
  - From: Bernd Schmidt
- Re: basic_block flags, BB_VISITED
  - From: Richard Biener

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]