This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: [GCC Steering Committee attention] [PING] [PING] [PING] libgomp: In OpenACC testing, cycle though $offload_targets, and by default only build for the offload target that we're actually going to test
- From: Ian Lance Taylor <iant at google dot com>
- To: Manuel López-Ibáñez <lopezibanez at gmail dot com>
- Cc: James Greenhalgh <james dot greenhalgh at arm dot com>, Thomas Schwinge <thomas at codesourcery dot com>, Jakub Jelinek <jakub at redhat dot com>, gcc Mailing List <gcc at gcc dot gnu dot org>, David Edelsohn <edelsohn at gnu dot org>, nd at arm dot com
- Date: Fri, 5 Aug 2016 09:27:06 -0700
- Subject: Re: [GCC Steering Committee attention] [PING] [PING] [PING] libgomp: In OpenACC testing, cycle though $offload_targets, and by default only build for the offload target that we're actually going to test
- Authentication-results: sourceware.org; auth=none
- References: <87mvlln7sc.fsf@hertz.schwinge.homeip.net> <87r3aole6j.fsf@hertz.schwinge.homeip.net> <87r3afjcff.fsf@hertz.schwinge.homeip.net> <87invg7fnk.fsf@kepler.schwinge.homeip.net> <9d67cbcb-971f-62f0-5cc1-797d387dbab7@gmail.com> <20160805140618.GA27810@arm.com> <CAESRpQAB+zVKFAEzvKD5hcHU51YNhrRp-GTe14z3V7zvxichTw@mail.gmail.com>
I'm not going to reply to any specific points, but I do want to
comment that I've come to believe that e-mail based patch review is a
problem. Unfortunately, I do not foresee the GCC maintainers moving
away from it.
I believe that Diego tried setting up an alternative patch review
system using Reitveld, but it did not catch on.
For Go development I have been using Gerrit, an instance hosted at
Google (https://go-review.googlesource.com/). It's just a much better
way of doing patch review. You can do line by line comments, you can
easily see the set of all patches and their state, you can assign the
patch review to specific people, you can easily commit the patch. For
Go we have trybots, which can be used to build the toolchain with the
patch and run all the tests on a range of different architectures and
operating systems.
Gerrit is free software under the Apache license
(https://www.gerritcodereview.com/).
It's not perfect: in particular, there is no offline code review. But
overall it's just much much better than what we do today in GCC.
But the active maintainers are accustomed to the current system, and
it would be very hard to change.
Ian