This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Enable EBX for x86 in 32bits PIC code

From: Jeff Law <law at redhat dot com>
To: Ilya Enkovich <enkovich dot gnu at gmail dot com>, Vladimir Makarov <vmakarov at redhat dot com>
Cc: gcc at gnu dot org, gcc-patches <gcc-patches at gcc dot gnu dot org>, Evgeny Stupachenko <evstupac at gmail dot com>, Richard Biener <richard dot guenther at gmail dot com>, Uros Bizjak <ubizjak at gmail dot com>
Date: Wed, 27 Aug 2014 15:39:14 -0600
Subject: Re: Enable EBX for x86 in 32bits PIC code
Authentication-results: sourceware.org; auth=none
References: <CAOvf_xxsQ_oYGqNAVQ1+BW+CuD3mzebZ2xma0jpF=WfyZMCRCA at mail dot gmail dot com> <CAFiYyc1mFtTezkTJORmJJq+yht=qPSwiN7KDn19+bSuSdaqvMQ at mail dot gmail dot com> <CAOvf_xyeVeg2oB9Xxz8RMEQ6gyfJY5whd9s4ygoAAEaMU9efnA at mail dot gmail dot com> <20140707114750 dot GB31640 at tucnak dot redhat dot com> <CAMbmDYZV_fx0jxmKHhLsC2pJ7pDzuu6toEAH72izOdpq6KGyfg at mail dot gmail dot com> <20140822121151 dot GA60032 at msticlxl57 dot ims dot intel dot com> <53FB5184 dot 3030500 at redhat dot com> <CAMbmDYbP77pmkqpJD8cnXbe7_8aRMnYF-tnfKRubULn8-aDCdw at mail dot gmail dot com> <CAMbmDYacBWjKtCYPB0A2m=fkUTk_Wt5D6f2aEkH7C3paWaR7ag at mail dot gmail dot com> <53FCA6F5 dot 7020405 at redhat dot com> <20140826213712 dot GA39451 at msticlxl57 dot ims dot intel dot com>

On 08/26/14 15:42, Ilya Enkovich wrote:

diff --git a/gcc/calls.c b/gcc/calls.c
index 4285ec1..85dae6b 100644
--- a/gcc/calls.c
+++ b/gcc/calls.c
@@ -1122,6 +1122,14 @@ initialize_argument_information (int num_actuals ATTRIBUTE_UNUSED,
      call_expr_arg_iterator iter;
      tree arg;

+    if (targetm.calls.implicit_pic_arg (fndecl ? fndecl : fntype))
+      {
+	gcc_assert (pic_offset_table_rtx);
+	args[j].tree_value = make_tree (ptr_type_node,
+					pic_offset_table_rtx);
+	j--;
+      }
+
      if (struct_value_addr_value)
        {
  	args[j].tree_value = struct_value_addr_value;

So why do you need this? Can't this be handled in the call/call_valueexpanders or what about attaching the use to CALL_INSN_FUNCTION_USAGEfrom inside ix86_expand_call? Basically I'm not seeing the need foranother target hook here. I think that would significantly simply thepatch as well.



Jeff

Follow-Ups:
- Re: Enable EBX for x86 in 32bits PIC code
  - From: Ilya Enkovich

References:
- Re: Enable EBX for x86 in 32bits PIC code
  - From: Ilya Enkovich
- Re: Enable EBX for x86 in 32bits PIC code
  - From: Vladimir Makarov
- Re: Enable EBX for x86 in 32bits PIC code
  - From: Ilya Enkovich
- Re: Enable EBX for x86 in 32bits PIC code
  - From: Ilya Enkovich
- Re: Enable EBX for x86 in 32bits PIC code
  - From: Vladimir Makarov
- Re: Enable EBX for x86 in 32bits PIC code
  - From: Ilya Enkovich

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]