This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Enable -Wreturn-type by default ?

From: Jeff Law <law at redhat dot com>
To: Jonathan Wakely <jwakely dot gcc at gmail dot com>, Sylvestre Ledru <sylvestre at debian dot org>
Cc: Dodji Seketeli <dodji at seketeli dot org>, "gcc at gcc dot gnu dot org" <gcc at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>
Date: Thu, 16 Jan 2014 10:03:39 -0700
Subject: Re: Enable -Wreturn-type by default ?
Authentication-results: sourceware.org; auth=none
References: <5283ABF2 dot 5010209 at debian dot org> <871u2jw776 dot fsf at seketeli dot org> <CAH6eHdRUrCrSsEV9ckq73QhTb0O-XREjN58Lv7xJfgk_0bH2eQ at mail dot gmail dot com> <5288E375 dot 4000907 at debian dot org> <CAH6eHdRmwurQXdRP+yB4WYu0U0jHxezBhnQAqwtrucnqnvL+0g at mail dot gmail dot com> <52D7BE77 dot 8090300 at debian dot org> <CAH6eHdTKCxajpj9U0nE7kAQNOQch1sFCUTGp4aPNQvcO-q0FAg at mail dot gmail dot com>

On 01/16/14 04:45, Jonathan Wakely wrote:

On 16 January 2014 11:11, Sylvestre Ledru wrote:

Hello,

On 17/11/2013 17:47, Jonathan Wakely wrote:

On 17 November 2013 15:40, Sylvestre Ledru wrote:

For "control reaches end of non-void function", I haven't activated by
default and I called the option -Wfalloff-nonvoid-function
Of course, that is just a proposal! :) Better names are welcome.

It was nearly called -Wmissing-return a decade ago, but got bundled
with -Wreturn-type, see
http://gcc.gnu.org/ml/gcc-patches/2002-02/msg02002.html

As discussed on this mailing list, I proposed a patch on the gcc-patches
mailing list.
http://gcc.gnu.org/ml/gcc-patches/2014-01/msg00820.html

Any chance one of you could review it?


I like the change in principle, but it's not up to me, I can't approve
front-end patches.  I can comment on the docs and ChangeLog but I'm
not subscribed to gcc-patches so didn't get the mail. I'll send some
comments, could you please reply to your gcc-patches mail and include
my comments? Thanks.

Note that your opinion is still quite important in this space though.

My gut tells me for C++ this is a no-brainer. For C it's less clear,but I think we still want it. Ultimately I suspect we're going to catchmore real bugs than false positives once we start looking at real coderather than the regression suite.

As long as folks writing code like Geoff K pointed out in the 2002thread can turn the warning off, I think we'll be OK.

So Sylvestre, the big part of the work is doing a bootstrap andregression test and it looks like you're well into that. Hopefully youcan wrap up soon.


jeff

References:
- Re: Enable -Wreturn-type by default ?
  - From: Sylvestre Ledru
- Re: Enable -Wreturn-type by default ?
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]