This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: To Steering Committee: RFC for patch revert policy (PR48403, bootstrap broken on many targets)
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Jeff Law <law at redhat dot com>, Bernd Schmidt <bernds at codesourcery dot com>, Ian Lance Taylor <iant at google dot com>, Steven Bosscher <stevenb dot gcc at gmail dot com>
- Cc: GCC Mailing List <gcc at gcc dot gnu dot org>, David Edelsohn <dje at gcc dot gnu dot org>, Benjamin Kosnik <bkoz at redhat dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Tue, 5 Apr 2011 03:23:30 -0400
- Subject: Re: To Steering Committee: RFC for patch revert policy (PR48403, bootstrap broken on many targets)
- References: <BANLkTi=AgWe2QOQ=bZ+a1XT7YQ1J1YKtyw@mail.gmail.com> <mcr1v1hfx5i.fsf@google.com> <4D9A6CDA.6080203@codesourcery.com> <4D9A7EAD.7010101@redhat.com>
On Mon, Apr 4, 2011 at 10:30 PM, Jeff Law <law@redhat.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 04/04/11 19:14, Bernd Schmidt wrote:
>>>
>> Another danger is getting a mob effect as in PR48403 (which I've also
>> seen happen on other occasions) and getting the wrong set of patches
>> reverted by trigger-happy people. To be blunt, there are some people on
>> this list who tend to react panicky to bugs and skip proper analysis (as
>> in this case); I don't want to encourage such folks to revert stuff
>> willy-nilly. Sometimes you just need a bit of time and assistance from
>> testers who actually see the problem to understand it.
>>
>> If there's a change in policy I'd at least make allowances for weekends.
>> There's considerably less traffic on the mailing lists on Saturdays and
>> Sundays, which suggests few people will be inconvenienced if the tree is
>> broken during such a time. We also don't want everyone to only check
>> things in on Mondays because they worry they'll come back after a
>> weekend to find their stuff gone from the tree.
> I definitely think that if there is a policy change that an allowance be
> made for weekends/holidays and that if a patch has been identified and
> the offender has acknowledged the issue and is actively working on the
> problem give the offender time to resolve the issue.
If a developer breaks bootstrap and cannot fix it immediately, the
patch should be reverted and the developer can fix the patch offline
and re-merge the patch. The focus of the policy should not be the
convenience of the developer who broke bootstrap on multiple targets.
- David