This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Fwd: r168382 - in /trunk/libstdc++-v3: ChangeLog Mak...


I think gcc-cvs mail list should set reply address to gcc@gcc.gnu.org
instead of gcc-cvs@gcc.gnu.org.

---------- Forwarded message ----------
From: Dongsheng Song <dongsheng.song@gmail.com>
Date: Sat, Jan 1, 2011 at 11:29
Subject: Re: r168382 - in /trunk/libstdc++-v3: ChangeLog Mak...
To: bkoz@gcc.gnu.org
Cc: gcc-cvs@gcc.gnu.org


Hi Benjamin,

Your commit have 2 drawbacks:

1. Âinsufficient docbook xsl path checker (trunk/libstdc++-v3/configure.ac)

# Check for docbook
AC_CHECK_PROG([XSLTPROC], xsltproc, yes, no)
AC_CHECK_PROG([XMLLINT], xmllint, yes, no)
AC_CHECK_FILE([/usr/share/sgml/docbook/xsl-ns-stylesheets/VERSION],
      Â[glibcxx_stylesheets=yes], [glibcxx_stylesheets=no])

For Debian, here is the correct path:
-rw-r--r-- 1 root root 4510 Jul 22 Â2009
/usr/share/xml/docbook/stylesheet/docbook-xsl-ns/VERSION
-rw-r--r-- 1 root root 4504 Jul 21 Â2009
/usr/share/xml/docbook/stylesheet/docbook-xsl/VERSION

2. Âbreak cross compiling (trunk/libstdc++-v3/configure)

{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for
/usr/share/sgml/docbook/xsl-ns-stylesheets/VERSION" >&5
$as_echo_n "checking for
/usr/share/sgml/docbook/xsl-ns-stylesheets/VERSION... " >&6; }
if test "${ac_cv_file__usr_share_sgml_docbook_xsl_ns_stylesheets_VERSION+set}"
= set; then :
Â$as_echo_n "(cached) " >&6
else
Âtest "$cross_compiling" = yes &&
Âas_fn_error "cannot check for file existence when cross compiling" "$LINENO" 5
if test -r "/usr/share/sgml/docbook/xsl-ns-stylesheets/VERSION"; then
Âac_cv_file__usr_share_sgml_docbook_xsl_ns_stylesheets_VERSION=yes
else
Âac_cv_file__usr_share_sgml_docbook_xsl_ns_stylesheets_VERSION=no
fi
fi

After as_fn_error, my cross compiling failed without use hard code path.

--
Dongsheng

On Sat, Jan 1, 2011 at 06:20, Â<bkoz@gcc.gnu.org> wrote:
> Author: bkoz
> Date: Fri Dec 31 22:20:22 2010
> New Revision: 168382
>
> URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=168382
> Log:
> 2010-12-31 ÂBenjamin Kosnik Â<bkoz@redhat.com>
>
> Â Â Â Â* scripts/run_doxygen: Allow doxygen 1.7.1 again.
>
> Â Â Â Â* doc/xml/manual/build_hacking.xml: Update.
> Â Â Â Â* doc/xml/images/confdeps.dot: Same.
> Â Â Â Â* doc/xml/images/confdeps.png: Same.
>
> Â Â Â Â* configure.ac: Define BUILD_INFO, BUILD_XML, BUILD_HTML,
> Â Â Â ÂBUILD_MAN, BUILD_PDF, BUILD_EPUB conditionally.
> Â Â Â Â* Makefile.am (xml, html, pdf, man, info, pd, dvi, epub): Define,
> Â Â Â Âand install rules.
> Â Â Â Â* doc/Makefile.am: Same. Add stamp rules.
> Â Â Â Â(doc-epub-docbook): Add.
> Â Â Â Â(stamp-xml-single-docbook): Make set too.
> Â Â Â Â* configure: Regenerate.
> Â Â Â Â* Makefile.in: Same.
> Â Â Â Â* doc/Makefile.in: Same.
> Â Â Â Â* include/Makefile.in: Same.
> Â Â Â Â* libsupc++/Makefile.in: Same.
> Â Â Â Â* po/Makefile.in: Same.
> Â Â Â Â* python/Makefile.in: Same.
> Â Â Â Â* src/Makefile.in: Same.
> Â Â Â Â* testsuite/Makefile.in: Same.
> Â Â Â Â* aclocal.m4: Same.
>
> 2010-12-31 ÂBenjamin Kosnik Â<bkoz@redhat.com>
>
> Â Â Â Â* doc/doxygen/user.cfg.in: Disable PDF_HYPERLINKS.
>
>
> Modified:
> Â Âtrunk/libstdc++-v3/ChangeLog
> Â Âtrunk/libstdc++-v3/Makefile.am
> Â Âtrunk/libstdc++-v3/Makefile.in
> Â Âtrunk/libstdc++-v3/aclocal.m4
> Â Âtrunk/libstdc++-v3/configure
> Â Âtrunk/libstdc++-v3/configure.ac
> Â Âtrunk/libstdc++-v3/doc/Makefile.am
> Â Âtrunk/libstdc++-v3/doc/Makefile.in
> Â Âtrunk/libstdc++-v3/doc/doxygen/user.cfg.in
> Â Âtrunk/libstdc++-v3/doc/xml/images/confdeps.dot
> Â Âtrunk/libstdc++-v3/doc/xml/manual/build_hacking.xml
> Â Âtrunk/libstdc++-v3/include/Makefile.in
> Â Âtrunk/libstdc++-v3/libsupc++/Makefile.in
> Â Âtrunk/libstdc++-v3/po/Makefile.in
> Â Âtrunk/libstdc++-v3/python/Makefile.in
> Â Âtrunk/libstdc++-v3/scripts/run_doxygen
> Â Âtrunk/libstdc++-v3/src/Makefile.in
> Â Âtrunk/libstdc++-v3/testsuite/Makefile.in
>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]