This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] i8k: Tell gcc that *regs gets clobbered

From: Jim Bos <jim876 at xs4all dot nl>
To: Linus Torvalds <torvalds at linux-foundation dot org>
Cc: Andreas Schwab <schwab at redhat dot com>, Andi Kleen <andi at firstfloor dot org>, Michael Matz <matz at suse dot de>, Dave Korn <dave dot korn dot cygwin at gmail dot com>, Richard Guenther <richard dot guenther at gmail dot com>, Linux Kernel Mailing List <linux-kernel at vger dot kernel dot org>, gcc at gcc dot gnu dot org
Date: Sat, 13 Nov 2010 12:13:53 +0100
Subject: [PATCH] i8k: Tell gcc that *regs gets clobbered
References: <4CD538CA.8010901@xs4all.nl> <87wroostw3.fsf@basil.nowhere.org> <m2hbfsu57i.fsf@igel.home> <87k4kospnd.fsf@basil.nowhere.org> <AANLkTikG6kBxSrO7EZ5_nZqTKqo8Rjm2stoEGVJWxanz@mail.gmail.com> <877hgorrj1.fsf@basil.nowhere.org> <4CD843DC.10106@gmail.com> <Pine.LNX.4.64.1011091352460.29956@wotan.suse.de> <20101109134816.GB29433@basil.fritz.box> <m3lj52txaq.fsf@redhat.com> <4CD97A3D.1040602@xs4all.nl>


More recent GCC caused the i8k driver to stop working, on Slackware
compiler was upgraded from gcc-4.4.4 to gcc-4.5.1 after which it
didn't work anymore, meaning the driver didn't load or gave total
nonsensical output.
As it turned out the asm(..) statement forgot to mention it modifies
the *regs variable.
Credits to Andi Kleen <andi@firstfloor.org> and Andreas Schwab
<schwab@linux-m68k.org> for providing the fix.

Signed-off-by: Jim Bos <jim876@xs4all.nl>

Attachment: PATCH.i8k.c
Description: Text document

References:
- Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/i8k.c ?
  - From: Andi Kleen
- Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/i8k.c ?
  - From: Andreas Schwab
- Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/i8k.c ?
  - From: Andi Kleen
- Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/i8k.c ?
  - From: Richard Guenther
- Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/i8k.c ?
  - From: Andi Kleen
- Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/i8k.c ?
  - From: Dave Korn
- Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/i8k.c ?
  - From: Michael Matz
- Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/i8k.c ?
  - From: Andi Kleen
- Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/i8k.c ?
  - From: Andreas Schwab
- Re: gcc 4.5.1 / as 2.20.51.0.11 miscompiling drivers/char/i8k.c ?
  - From: Jim

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]