This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Help ! Frozen by a comment in gcc/c-common.h!


Hi!

On Thu, Aug 27, 2009 at 09:51:30AM -0700, Ian Lance Taylor wrote:
> I suspect that that comment is no longer relevant.  At least, I can't
> seem to find the mask.  Perhaps somebody else knows.

I got. Since no anybody more has commented, let us be sure that the
mask mechanism has gone. [I've recently found corresponding bit mask in
gcc-3.3.6 in grokdeclarator (c-decl.c), e.g:
> 3589               if (i == RID_LONG && (specbits & (1 << (int) RID_LONG)))
or
> 3624               specbits |= 1 << (int) i;
where
> 3586           enum rid i = C_RID_CODE (id);
]

So for the sake of those who will develop C-derived front ends, should
we change the comment like below:
> /* Reserved identifiers.  This is the union of all the keywords for C,
>    C++, and Objective-C.  In the past, in earlier GCC versions all the
>    type modifiers had to be in one block at the beginning, because
>    they were used as mask bits.  There were 27 type modifiers; so if
>    anybody added many more the mask mechanism would have to be
>    redesigned.  Now it doesn't matter, since corresponding mask
>    machinery gone */
Should I (or you) submit a patch?

Alexei I. Adamovich


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]