This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: [gnat] reuse of ASTs already constructed
Robert Dewar wrote:
>
> I don't see that Str3 is free in any of these nodes, what
> nodes are you talking about (remember that Str3 overlaps
> Node3, List3 etc).
Okay.
> >>>> How about not doing the name expansion in-place but rather
> >>>> storing the expanded name in an extra node field?
>
> You could have a separate vector for expanded names I suppose ...
So be it. I will change the code to not overwrite the Name field
with the expanded name but rather store the expanded name in a
data structure separate from the Node.
Any thoughts on my questions related to gnatmake?
Further question, what is the process for integrating my changes
into the GCC trunk?
I would assume that I need to
1) Make my modifications complete and functioning
2) Make sure bootstrap works for all languages
3) Run the gcc testsuite and make sure I do not introduce regressions
4) What about testing on different platforms? I'm only testing on x86
SuSE Linux and setting up other platforms could be a problem.
(Coming to think, I could actually test on x86_64 SuSE Linux with
small effort, though.)
5) Copyright assignment should be on file at FSF, please check
6) Anything else?
Thanks,
Oliver