This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Missing gen_sse2_cvtdq2p in convert splitter?


On Wed, Oct 8, 2008 at 8:29 AM, H.J. Lu <hjl.tools@gmail.com> wrote:

> I386.md has
>
> (define_split
>  [(set (match_operand:MODEF 0 "register_operand" "")
>        (float:MODEF (match_operand:SI 1 "register_operand" "")))]
>  "TARGET_SSE2 && TARGET_SSE_MATH
>   && TARGET_USE_VECTOR_CONVERTS && optimize_function_for_speed_p (cfun)
>   && reload_completed
>   && (SSE_REG_P (operands[0])
>       || (GET_CODE (operands[0]) == SUBREG
>           && SSE_REG_P (operands[0])))"
>  [(const_int 0)]
> {
>  rtx op1 = operands[1];
>
>  operands[3] = simplify_gen_subreg (<ssevecmode>mode, operands[0],
>                                     <MODE>mode, 0);
>  if (GET_CODE (op1) == SUBREG)
>    op1 = SUBREG_REG (op1);
>
>  if (GENERAL_REG_P (op1) && TARGET_INTER_UNIT_MOVES)
>    {
>      operands[4] = simplify_gen_subreg (V4SImode, operands[0], <MODE>mode, 0);
>      emit_insn (gen_sse2_loadld (operands[4],
>                                  CONST0_RTX (V4SImode), operands[1]));
>    }
>  /* We can ignore possible trapping value in the
>     high part of SSE register for non-trapping math. */
>  else if (SSE_REG_P (op1) && !flag_trapping_math)
>    operands[4] = simplify_gen_subreg (V4SImode, operands[1], SImode, 0);
>  else
>    gcc_unreachable ();
> })
>
> Aren't
>
>  emit_insn
>    (gen_sse2_cvtdq2p<ssemodefsuffix> (operands[3], operands[4]));
>  DONE;
>
> missing at the end?

Uh, yes.

The patch is pre-approved as obvious.

Thanks,
Uros.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]