This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Is that OK to borrow code from coreutils?


On Wed, Jul 9, 2008 at 11:48 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> In that chmod() is not defined by the Fortran Standard,
>> how can you infer that libgfortran's implementation is
>> incorrect?
>>
>
> Please read a decent UNIX system book or look how
> system () is implemented in glibc.

Well, there's a helpful answer!

You obviously want to change libgfortran for some reason.  It seems
only normal to me that you make an effort to explain why you think
this is necessary.  AFAIK the chmod in libgfortran, and in libg2c
before that, has never been a problem for anyone.  And with the basic
rule "If it ain't broke, don't fix it" in mind, there is no reason to
change the implementation to something more sophisticated.

So what problem are you trying to solve?  Got a test case?  Please
don't point back to the PR again, you're not explaining the problem
there either, only the symptom.  Surely, you didn't wonder off into
libgfortran land if you didn't have a piece of real world code that
has issues with the current libgfortran chmod? ;-)

Gr.
Steven


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]