This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: I need some advice for x86_64-pc-mingw32 va_list calling convention (in i386.c)
- From: "Andrew Pinski" <pinskia at gmail dot com>
- To: "Kai Tietz" <Kai dot Tietz at onevision dot com>
- Cc: "Richard Henderson" <rth at redhat dot com>, "Menezes, Evandro" <evandro dot menezes at amd dot com>, gcc <gcc at gcc dot gnu dot org>
- Date: Tue, 27 Feb 2007 01:19:44 -0800
- Subject: Re: I need some advice for x86_64-pc-mingw32 va_list calling convention (in i386.c)
- Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=iBEv8ei7znICeFcXgdo1pvIg0s9MGVopGYOnhIQJwqI8f6zDgTKv2JiRB4VIdn4BBJrbiF50nGfcsI3bwocjbCpVzKbvvjdm+GwlUiO68qTp9mn5DStkfEI1hgJzzDRs+Htag2co+wDR/2t0OLeUUaBWz+Vx4gl0Axlg33jAcK4=
- References: <20070226181026.GA32115@redhat.com> <OF57D646CB.9BE60BE9-ONC125728F.00300E86-C125728F.0030ACC4@onevision.de>
On 2/27/07, Kai Tietz <Kai.Tietz@onevision.com> wrote:
Thank you,
I allready adjusted my code. But by the reason of the need to define
OUTGOING_REG_PARM_STACK_SPACE for this target, I had to change the general
definition of it to be target specific.
This is why the uses of OUTGOING_REG_PARM_STACK_SPACE should really be
changed to be if(OUTGOING_REG_PARM_STACK_SPACE) instead of #ifdef
OUTGOING_REG_PARM_STACK_SPACE.
There was an email a while back from Zack Weinberg and Hans-Peter
Nilsson which talks explictly about how chaning this has saved
maintaining and finding bugs in the compiler.
<http://gcc.gnu.org/ml/gcc/2001-01/msg01775.html and
http://gcc.gnu.org/ml/gcc/2001-01/msg01777.html>
And I thought this was really part of our coding style too but I
cannot find it on http://gcc.gnu.org/codingconventions.html .
Thanks,
Andrew Pinski