This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: expand_builtin_memcpy bug exposed by TER and gfortran

From: "Steven Bosscher" <stevenb dot gcc at gmail dot com>
To: "Andrew MacLeod" <amacleod at redhat dot com>
Cc: "gcc mailing list" <gcc at gcc dot gnu dot org>
Date: Tue, 5 Dec 2006 20:52:04 +0100
Subject: Re: expand_builtin_memcpy bug exposed by TER and gfortran
References: <1165342689.3202.6.camel@localhost.localdomain>

On 12/5/06, Andrew MacLeod <amacleod@redhat.com> wrote:

My preference is to check in the TER code which exposes this bug, and
open a PR against the failure with this info.  That way we don't lose
track of the problem, and someone can fix it at their leisure. Until
then there will be a testsuite failure in gfortran for the testcase
which triggers this.

Does that seem reasonable? or would everyone prefer I get it fixed
before checking in the TER code?

No, IMHO.

It's unfortunate enough if a patch introduces a bug that we only find
later.  It's Very Bad And Very Wrong to allow in patches that cause
test suite failures.

Frankly, I don't understand why you even ask.  We have rules for
testing for a reason.

Gr.
Steven

References:
- expand_builtin_memcpy bug exposed by TER and gfortran
  - From: Andrew MacLeod

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]