This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Re: conversion warnings in c++


On Fri, 13 Jan 2006, Eric Christopher wrote:

|
| > | OK?
| >
| > yes.
| >
| > | Did you want me to add this as a testcase?
| >
| > yes -- so that we don't regress.
|
| Ok. apparently I tested in the wrong directory and we already have a
| few testcases that test whether we're emitting warnings. I've cleaned
| up the testsuite (and added a quick patch to cvt.c to add another
| check on OPT_Wconversion), but I'll ask for approval again, because
| it's quite a few changes.
|
| So, this ok or would you like me to leave some of the warnings there?
| None of them are pedwarns so I'm assuming (based on a quick look
| through the standard) that they aren't necessary and can be
| conditionalized, but I wanted to double check.


Hi Eric,


 The overall patch is OK.  Please could add testcases that test
-Wno-conversion?  Thanks for doing this.

-- Gaby


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]