This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: weakref miscompiling libgfortran
- From: Andrew Pinski <pinskia at physics dot uc dot edu>
- To: jakub at redhat dot com
- Cc: geoffk at geoffk dot org (Geoff Keating), rth at redhat dot com (Richard Henderson), aoliva at redhat dot com (Alexandre Oliva), gcc at gcc dot gnu dot org
- Date: Tue, 27 Dec 2005 12:38:16 -0500 (EST)
- Subject: Re: weakref miscompiling libgfortran
>
> On Mon, Dec 26, 2005 at 11:34:16PM -0800, Geoff Keating wrote:
> > We've had Real Problems with this feature since it was introduced. I
> > expect it'll take at least another two or three months before it
> > settles down and starts to work on most targets; that's only to be
> > expected for such a far-reaching change to GCC's capabilities.
>
> It works just fine on ELF targets on gcc-4_1-branch, where you haven't
> applied your set of changes (as well as in the 4.0, 3.4 and 3.2 backports
> Alex did).
>
> More importantly, it is very wrong if GCC 4.1 and 4.2 weakrefs are
> incompatible in their user visible part (trunk requires
> static __typeof (bar) foo __attribute__ ((weakref ("bar")))
> while 4.1 requires
> extern __typeof (bar) foo __attribute__ ((weakref ("bar")))
> ).
>
> IMHO this needs to be resolved before GCC 4.1 is released, so very soon.
Let me make the point that the weakref patch has caused more problems by
applying it for 4.1 (very late in stage3) than what it would have resolved.
I think it should be just reverted on the 4.1 branch because it obviously
have not been tested that well on non GNU/Linux machines and has not been
thought about as much as it should be.
-- Pinski