This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: GCSE considers read only memory clobbered by function calls.
- From: Jeffrey A Law <law at redhat dot com>
- To: Mostafa Hagog <MUSTAFA at il dot ibm dot com>
- Cc: gcc at gcc dot gnu dot org, stevenb at suse dot de
- Date: Tue, 31 May 2005 08:33:14 -0600
- Subject: Re: GCSE considers read only memory clobbered by function calls.
- References: <OFCE5F51B1.05ECD87B-ONC225700A.0029CBE5-C225700A.002AC850@il.ibm.com>
- Reply-to: law at redhat dot com
On Mon, 2005-05-23 at 10:47 +0300, Mostafa Hagog wrote:
>
>
>
>
> Jeffrey A Law <law@redhat.com> wrote on 09/05/2005 18:17:45:
>
> > Yes, it looks quite reasonable. Please go ahead with the full testing
> > cycle and consider the patch pre-approved once complete.
> >
> I have changed the patch according to some feedbacks that I have got -- the
> main idea didn't change. One change is to check the MEM_READONLY_P flag
> also in load_killed_in_block. The new patch is attached below. bootstrap
> passed (with -O2 -g -fgcse -fgcse-las --param max-gcse-passes=3) and no new
> regressions on powerpc-apple-darwin.
>
> Since I have changed the patch a bit I am asking again for approval to
> commit.
>
> 2005-05-23 Mostafa Hagog <mustafa@il.ibm.com>
>
> * gcse.c (compute_transp, load_killed_in_block): use MEM_READONLY_P.
This is fine. Please install.
Thanks,
Jeff