This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: postreload-gcse heuristics broken?
- From: Ulrich Weigand <Ulrich dot Weigand at de dot ibm dot com>
- To: Mostafa Hagog <MUSTAFA at il dot ibm dot com>
- Cc: Ayal Zaks <ZAKS at il dot ibm dot com>, gcc at gcc dot gnu dot org
- Date: Wed, 26 Jan 2005 16:47:22 +0100
- Subject: Re: postreload-gcse heuristics broken?
Mostafa Hagog/Haifa/IBM wrote on 01/25/2005 11:10:50 PM:
> Here is an updated patch, can you please test it?
It does work. But are you sure you wanted to keep this hunk:
*************** eliminate_partially_redundant_load (basi
*** 1030,1035 ****
--- 1031,1040 ----
if (reg_set_or_used_since_bb_start (dest, bb, insn))
return;
+ FOR_EACH_EDGE (pred, ei, bb->preds)
+ if (EDGE_CRITICAL_P (pred))
+ return;
+
/* Check potential for replacing load with copy for predecessors. */
FOR_EACH_EDGE (pred, ei, bb->preds)
{
It would appear the later tests for EDGE_CRITICAL_P are quite
pointless after this ...
Mit freundlichen Gruessen / Best Regards
Ulrich Weigand
--
Dr. Ulrich Weigand
Linux for S/390 Design & Development
IBM Deutschland Entwicklung GmbH, Schoenaicher Str. 220, 71032 Boeblingen
Phone: +49-7031/16-3727 --- Email: Ulrich.Weigand@de.ibm.com