This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Mainline is broken on ia64


On Thu, Nov 04, 2004 at 03:02:42PM -0500, Andrew Pinski wrote:
> 
> On Nov 4, 2004, at 2:58 PM, Andrew Pinski wrote:
> 
> >
> >On Nov 4, 2004, at 2:54 PM, H. J. Lu wrote:
> >
> >>Mainline is broken on ia64:
> >>
> >>cc1: warnings being treated as errors
> >>/net/gnu/export/gnu/src/gcc/gcc/gcc/flow.c: In function
> >>'init_propagate_block_info':
> >>/net/gnu/export/gnu/src/gcc/gcc/gcc/flow.c:1890: warning: pointer
> >>targets in passing argument 4 of 'bmp_iter_set_init' differ in
> >>signedness /net/gnu/export/gnu/src/gcc/gcc/gcc/flow.c:1890: warning:
> >>pointer targets in passing argument 2 of 'bmp_iter_set' differ in
> >>signedness /net/gnu/export/gnu/src/gcc/gcc/gcc/flow.c:1890: warning:
> >>pointer targets in passing argument 2 of 'bmp_iter_next' differ in
> >>signedness make[4]: *** [flow.o] Error 1
> >
> >Can you try this patch?  I will apply it as obvious if it passes for 
> >you.
> >
> >ChangeLog:
> >	* flow.c (init_propagate_block_info): Change the type of i to 
> >unsigned.
> 
> Obviously I had a typo in my patch, I misspelled unsigned.
> 
> Thanks,
> Andrew Pinski
> 

> Index: flow.c
> ===================================================================
> RCS file: /cvs/gcc/gcc/gcc/flow.c,v
> retrieving revision 1.604
> diff -u -p -r1.604 flow.c
> --- flow.c	2 Nov 2004 20:30:50 -0000	1.604
> +++ flow.c	4 Nov 2004 20:01:40 -0000
> @@ -1821,7 +1821,7 @@ init_propagate_block_info (basic_block b
>        regset_head diff_head;
>        regset diff = INITIALIZE_REG_SET (diff_head);
>        basic_block bb_true, bb_false;
> -      int i;
> +      unsigned i;
>  
>        /* Identify the successor blocks.  */
>        bb_true = EDGE_SUCC (bb, 0)->dest;

It works. This one also works.


H.J.
2004-11-04  H.J. Lu  <hongjiu.lu@intel.com>

	* flow.c (init_propagate_block_info): Correct signedness for
	EXECUTE_IF_SET_IN_REG_SET.

--- flow.c.sign	2004-11-04 09:13:00.000000000 -0800
+++ flow.c	2004-11-04 12:18:23.374179652 -0800
@@ -1821,7 +1821,6 @@ init_propagate_block_info (basic_block b
       regset_head diff_head;
       regset diff = INITIALIZE_REG_SET (diff_head);
       basic_block bb_true, bb_false;
-      int i;
 
       /* Identify the successor blocks.  */
       bb_true = EDGE_SUCC (bb, 0)->dest;
@@ -1876,6 +1875,7 @@ init_propagate_block_info (basic_block b
 				  GET_MODE (cond_true), XEXP (cond_true, 0),
 				  XEXP (cond_true, 1));
 	      reg_set_iterator rsi;
+	      unsigned i;
 
 	      if (GET_CODE (XEXP (set_src, 1)) == PC)
 		{


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]