This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Problems with "make check"


>>>>> "Phil" == Phil Edwards <phil at jaj dot com> writes:

Phil> You're not the first.  :-) It would require a one-line change to
Phil> automake's $share/am/dejagnu.am, and I'm not sure what else.

That should be it.  However, that's automake 1.4.  I doubt the current
maintainer would want to do another 1.4.x release.  libgcj already has
a mini-fork though; you could put it there.

The code in there is a little weird in another way:

	runtest=$(RUNTEST); \
## If runtest can't be found, print a warning but don't die.  It is
## pointless to cause a failure if the tests cannot be run at all.
	if $(SHELL) -c "$$runtest --version" > /dev/null 2>&1; then \
	  l='$(DEJATOOL)'; for tool in $$l; do \
	    $$runtest $(AM_RUNTESTFLAGS) $(RUNTESTDEFAULTFLAGS) $(RUNTESTFLAGS); \
	  done; \
	else echo "WARNING: could not find \`runtest'" 1>&2; :;\

This seems backwards now.  I mean, wouldn't you want a failure if you
can't run the tests?  So that you know they didn't get run?

Some of this older code just copied existing practice, though,
independent of whether said practice made sense.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]