This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/RFA] SH: DWARF2 exception handling


kaz Kojima wrote:
> 
> Hi,
> 
> This patch is mainly for exception handling using DWARF2 on
> sh-linux targets.
> Bootstrapped and no new regressions on sh4-unknown-linux-gnu.
> I'm not certain this is ok for sh64-linux. Steve, does this
> work for you?

Sorry this took so long, I thought Steve would be looking at this.

Please describe the purpose of all the changes.

New functions should also have comments at the top to describe what
they do.

It seems that you actually know sh-linux (for SH1 .. SH4) better
than me.  Would you be interested in becoming a gcc sub-maintainer
for sh-linux?

>         * config/sh/sh.c (push_reg): Push PR_MEDIA_REG last.

This bit doesn't make sense.  push_regs is not executed for TARGET_SH5.

>         * config/sh/sh.h (SH_DBX_REGISTER_NUMBER): Handle PR_MEDIA_REG.

I just happened to find this independently last week - it is also needed
to get valid call frame debugging information.

>         Don't abort even if the number is mapped to -1.

Why?  When is that expected to be valid?
	
	
-- 
--------------------------
SuperH (UK) Ltd.
2410 Aztec West / Almondsbury / BRISTOL / BS32 4QX
T:+44 1454 465658


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]