Re: bug introduced by inlining patch

[Gerald Pfeifer <pfeifer at dbai dot tuwien dot ac dot at>]

On Wed, 4 Sep 2002, Kurt Garloff wrote:
> Well, in my patch collection at
> http://www.garloff.de/kurt/freesoft/gcc/
> there are patches for documentation included.
> But only in the newer patches, and I'm afriad an older one went into
> gcc.

I did some digging and found that

  2002-04-27  Kurt Garloff <garloff@suse.de>

        * tree-inline.c (inlinable_function_p): Improve heuristics
        by using a smoother function to cut down allowable inlinable size.
        * param.def: Add parameters max-inline-insns-single,
        max-inline-slope, min-inline-insns that determine the exact
        shape of the above function.
        * param.h: Likewise.

was installed 27-Apr-2002 by rth.

> I believe the first version of the patch got checked in by Gerald.

I believe there were further discussion during the month of May, among
rth, you and me (where I did some performance testing) and also Andreas
Jäger (concerning SPEC) but somehow it seems this thread then died down
without any further patch being applied...

> But, if this discussion is starting up again, I would like to propose
> my patch v4 (from the above webpage) for inclusion.
> I would appreciate a lot to get (positive and negative) criticism on it.

...therefore I'd like to suggest that you verify your latest patch
against current mainline and submit it to gcc-patches.

Gerald

> PS:[...] I guess the importance of inlinig heuristics has been underestimated
>  previously. Maybe due to the fact that people were focused on C which
>  does not make such heavy use of inlining as C++ (and other OOP lan-
>  guages).

Fully agreed.
-- 
Gerald "Jerry" pfeifer@dbai.tuwien.ac.at http://www.dbai.tuwien.ac.at/~pfeifer/