This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: typedef-named class member functions can be public
- From: Noel Yap <yap_noel at yahoo dot com>
- To: Richard Kenner <kenner at vlsi1 dot ultra dot nyu dot edu>, mark at codesourcery dot com
- Cc: gcc at gcc dot gnu dot org
- Date: Wed, 10 Jul 2002 06:13:27 -0700 (PDT)
- Subject: Re: typedef-named class member functions can be public
--- Richard Kenner <kenner@vlsi1.ultra.nyu.edu> wrote:
> You should not check in any patch without a
> testcase, unless a maintainer
> specifically waives that requirement.
>
> This will lead to forks. Alexandre's concern is a
> real one. I'd *much*
> prefer RedHat contribute the patch without a test
> case than not contribute
> the patch at all.
Test cases are important for long-term development.
I'm afraid that if a patch were checked in without
proper tests, proper tests will never be written.
Further, it opens the door for others to violate this
requirement.
When I was faced with a similar situation regarding a
patch for CVS, I made the patch publicly available
(without test cases) and referred it to those that
wanted the patch. Eventually, some people took the
time to create the test cases (and improve upon the
original :-). FWIW, someone is now working on
including the patch into the main CVS release.
M2C,
Noel
__________________________________________________
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com