This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Interesting Makefile race condition ...
- From: "Ulrich Weigand" <Ulrich dot Weigand at de dot ibm dot com>
- To: DJ Delorie <dj at redhat dot com>
- Cc: gcc at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Fri, 14 Jun 2002 16:40:56 +0200
- Subject: Re: Interesting Makefile race condition ...
- Sensitivity:
>DJ Delorie wrote:
>
>> How should this be fixed? Maybe any Makefile target using
>> $(GCC_FOR_TARGET) should depend on specs as well as on xgcc?
>
>That seems like an obvious fix to me.
Actually it looks like all other targets using $(GCC_FOR_TARGET)
already depend on specs, it is just missing for libgcc.mk.
So I committed the following patch as obvious. Bootstrapped on
s390-ibm-linux.
ChangeLog:
* Makefile.in (libgcc.mk): Depend on specs.
Index: gcc/Makefile.in
===================================================================
RCS file: /cvs/gcc/gcc/gcc/Makefile.in,v
retrieving revision 1.899
diff -c -p -r1.899 Makefile.in
*** gcc/Makefile.in 11 Jun 2002 20:06:04 -0000 1.899
--- gcc/Makefile.in 14 Jun 2002 13:57:05 -0000
*************** xlimits.h: glimits.h limitx.h limity.h
*** 994,1000 ****
LIB2ADD = $(LIB2FUNCS_EXTRA)
LIB2ADD_ST = $(LIB2FUNCS_STATIC_EXTRA)
! libgcc.mk: config.status Makefile mklibgcc $(LIB2ADD) $(LIB2ADD_ST) xgcc
$(exeext)
objext='$(objext)' \
LIB1ASMFUNCS='$(LIB1ASMFUNCS)' \
LIB2FUNCS_1='$(LIB2FUNCS_1)' \
--- 994,1000 ----
LIB2ADD = $(LIB2FUNCS_EXTRA)
LIB2ADD_ST = $(LIB2FUNCS_STATIC_EXTRA)
! libgcc.mk: config.status Makefile mklibgcc $(LIB2ADD) $(LIB2ADD_ST) xgcc
$(exeext) specs
objext='$(objext)' \
LIB1ASMFUNCS='$(LIB1ASMFUNCS)' \
LIB2FUNCS_1='$(LIB2FUNCS_1)' \
Mit freundlichen Gruessen / Best Regards
Ulrich Weigand
--
Dr. Ulrich Weigand
Linux for S/390 Design & Development
IBM Deutschland Entwicklung GmbH, Schoenaicher Str. 220, 71032 Boeblingen
Phone: +49-7031/16-3727 --- Email: Ulrich.Weigand@de.ibm.com