This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: commitinfo script to check policy, issue warnings (and/or abortcommit)
- To: <rittle at labs dot mot dot com>
- Subject: Re: commitinfo script to check policy, issue warnings (and/or abortcommit)
- From: "Joseph S. Myers" <jsm28 at cam dot ac dot uk>
- Date: Fri, 18 May 2001 20:58:10 +0100 (BST)
- cc: <gcc at gcc dot gnu dot org>
On Fri, 18 May 2001, Loren James Rittle wrote:
> In article <orsni5pu3k.fsf@guarana.lsd.ic.unicamp.br>,
> Alexandre Oliva <aoliva@redhat.com> writes:
>
> > Instead of $*, I'd rather use ${1+"$@"}
>
> I won't even ask why... OK.
I suggest simply using "$@". While robustness in the face of spaces in
filenames is a good idea (although no-one should try to commit such
filenames to the GCC tree), allowing for non-POSIX shells that don't
handle "$@" properly is surely an irrelevance for a script run on
gcc.gnu.org.
Could the script also give a warning if someone commits through the old
"egcs" link rather than the "gcc" directory? I'd like to see these
residual egcs references go away more from gcc-cvs. The script
contrib/newcvsroot allows someone to convert easily.
--
Joseph S. Myers
jsm28@cam.ac.uk