This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: commitinfo script to check policy, issue warnings (and/or abortcommit)


On Fri, 18 May 2001, Loren James Rittle wrote:

> In article <orsni5pu3k.fsf@guarana.lsd.ic.unicamp.br>,
> Alexandre Oliva <aoliva@redhat.com> writes:
> 
> > Instead of $*, I'd rather use ${1+"$@"}
> 
> I won't even ask why...  OK.

I suggest simply using "$@".  While robustness in the face of spaces in 
filenames is a good idea (although no-one should try to commit such 
filenames to the GCC tree), allowing for non-POSIX shells that don't 
handle "$@" properly is surely an irrelevance for a script run on 
gcc.gnu.org.

Could the script also give a warning if someone commits through the old
"egcs" link rather than the "gcc" directory?  I'd like to see these
residual egcs references go away more from gcc-cvs.  The script 
contrib/newcvsroot allows someone to convert easily.

-- 
Joseph S. Myers
jsm28@cam.ac.uk


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]