This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Merged ARM-Thumb branch...


Hi Scott,

: > >Fri Jul 16 10:29:48 1999  Philip Blundell  <pb@futuretv.com>
: > >        * function.c (rtx_equal_for_addressof_p): New function.
: > >        (purge_addressof_1): Use it instead of rtx_equal_p.
: >
: > As far as I know, this bug is still present, but I'm not at all convinced that
: > my patch is the right answer.
: 
: Any comments would be appreciated then.

I suspect that you may want to resubmit this patch to gcc-patches,
since I doubt if the regualr readers of that list noticed it amoungst
all the ARM patches.

If you do submit it then they are almost certainly going to want to
know why this patch is necessary...

Also - why is rtl_equal_for_addressof_p() placed in function.c instead
of rtl.c ?  Surely it ought to go alongside rtl_equal_p() ?

Also - since most to the two functions are the same, why duplicate the
code ?  Wouldn't it be easier to perform the addressof specific tests
first and then just tailcall rtx_equal_p() if they all pass ?

Cheers
	Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]