This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: MIPS port and fixincludes


Joern Rennecke wrote:
> 
> > [[...]]  For example, it is
> > pointless to change "sparc" to "__sparc__" on an IA86 box.
> 
> No it isn't.  The user is free to define sparc.  (S)he shouldn't
> get sparc-specific code on an IA86 box as a result.

Good argument.  The only minor issue is consistency.
We don't fix every occurrance of every inappropriate
machine/os #define test.  Doing the fix, however, also
yields a nasty surprise if the code were to be compiled
on the "native" IA86 compiler that does not fix the
"sparc" reference.  On balance, I would prefer not
changing references to values that are not #defined:

1. it will substantially reduce the number
   of secret header files
2. it would reduce include fixing time by another half.
3. it would be more consistent (If we don't fix them all,
   then we should only fix what we must.)

On the other hand, it is fairly picayune anyway.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]