This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: untested changes (was re: patch applied to reload1.c)
- To: davem at dm dot cobaltmicro dot com (David S. Miller)
- Subject: Re: untested changes (was re: patch applied to reload1.c)
- From: Joern Rennecke <amylaar at cygnus dot co dot uk>
- Date: Sat, 26 Sep 1998 03:19:48 +0100 (BST)
- Cc: egcs at cygnus dot com
> Thanks. However, the coding standards say to avoid assignments inside
> conditions, so reverted the code to use a separate assignment.
>
> Thats sort of hypocritcal considering how the rest of reload (and
> actually, most of the entire compiler) does this everywhere.
This usually happens where the assignment needs to be guarded by
some preliminary checks, so there is no easy way to convert this code.
If you find places where assignments are placed in if conditions for
no good reason, consider submitting a patch.