This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: gcc.c warning cleanup
- To: egcs at cygnus dot com, robertl at dgii dot com
- Subject: Re: gcc.c warning cleanup
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Date: Sat, 7 Feb 1998 14:47:27 -0500 (EST)
> From: Robert Lipe <robertl@dgii.com>
>
> A few remain in this file, but I think that most of them are due to
> the flow analysis thing (if/then/else) that somone (rth?) mentioned
> recently.
>
>
> Fri Feb 6 01:21:03 1998 Robert Lipe <robertl@dgii.com>
>
> * gcc.c Include <strings.h>, <stdlib.h>, <unistd.h>, <fcntl.h>.
> (free_path_suffix): Remove unreferenced static function.
> (process_command): Remove unused variable temp.
> (default_arg): Remove unused variable i.
> (do_spec_1): Add parens for assignment used as truth value.
> (main): Likewise.
> (validate_all_switches): Likewise.
> (main): Remove unused variables i, first_time>
Hi Robert,
Thanks for helping out. Your patch looks great, it looks like
you also plugged a tiny memory leak when you got rid of variable
`temp' in process_command().
The only suggestion I have is that for strings.h you follow
the convention of including string.h first and only get strings.h if
string.h doesn't exist. Ie,
> #ifdef HAVE_STRING_H
> # include <string.h>
> #else
> # ifdef HAVE_STRINGS_H
> # include <strings.h>
> # endif
> #endif
Great work.
--Kaveh
--
Kaveh R. Ghazi Project Manager / Custom Development
ghazi@caip.rutgers.edu ICon CMT Corp.