This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: [REPOST] MT-safe exception diffs for 971207
- To: egcs at cygnus dot com, tot at trema dot com, law at cygnus dot com
- Subject: Re: [REPOST] MT-safe exception diffs for 971207
- From: Jason Merrill <jason at cygnus dot com>
- Date: 11 Dec 1997 19:36:28 -0800
- Cc: wilson at cygnus dot com
- References: <199712111608.RAA16152.cygnus.egcs@lev.labs.trema.com>
- Reply-To: egcs at cygnus dot com
Looks great, thanks a lot! Some minor comments:
In use_eh_context, why are you using copy_rtx on a REG rtx? That's a nop.
I'm not sure why you need five functions to handle eh_context.
Indeed, the saved_pc stuff can be commented out ifdef DWARF2_UNWIND_INFO.
In fact, I'm about to blow away the old unwind code that uses saved_pc, so
you don't need to worry about making it work. I'll be removing it just
after your patch goes in.
Why do you cast &eh->info and &eh->dynamic_handler_chain to their own
types?
Since you only use ptr_ptr_type_node once, there's no need to save it in a
global variable.
I'd just as soon put this patch in now and get a second patch for these
tweaks; Jeff?
Jason