Re: GCC build of HEAD failed for native with your patch on 2004-01-29T07:33:22Z.

[Andrew Pinski <pinskia at physics dot uc dot edu>]

On Jan 29, 2004, at 01:43, GCC regression checker wrote:

> With your recent patch, GCC HEAD does not compile on:
>  native
> Attached is build output for those targets.
>
> The build failures are new.
>
> For more information, see http://gcc.gnu.org/regtest/.
>
> <ChangeLog.diff><native-log.txt>--
> Geoffrey Keating <geoffk@apple.com>
> (via an automated GCC regression-testing script.)


From this failure:
/Users/regress/tbox/native/build/gcc/xgcc -shared-libgcc  
-B/Users/regress/tbox/native/build/gcc/ -nostdinc++  
-L/Users/regress/tbox/native/build/powerpc-apple-darwin7.2.0/libstdc++- 
v3/src  
-L/Users/regress/tbox/native/build/powerpc-apple-darwin7.2.0/libstdc++- 
v3/src/.libs -B/Users/regress/tbox/objs/powerpc-apple-darwin7.2.0/bin/  
-B/Users/regress/tbox/objs/powerpc-apple-darwin7.2.0/lib/ -isystem  
/Users/regress/tbox/objs/powerpc-apple-darwin7.2.0/include -isystem  
/Users/regress/tbox/objs/powerpc-apple-darwin7.2.0/sys-include  
-dynamiclib -flat_namespace -undefined suppress -o  
.libs/libstdc++.6.0.0.dylib .libs/libstdc++.6.0.0.dylib-master.o    
-L/Users/regress/tbox/native/build/powerpc-apple-darwin7.2.0/libstdc++- 
v3/src  
-L/Users/regress/tbox/native/build/powerpc-apple-darwin7.2.0/libstdc++- 
v3/src/.libs -lm ../libmath/.libs/libmath.a -lm  
../libsupc++/.libs/libsupc++convenience.a -lm -lm   -lc  -install_name   
/Users/regress/tbox/objs/lib/libstdc++.6.dylib -compatibility_version 7  
-cur
 rent_version 7.0
ld: common symbols not allowed with MH_DYLIB output format with the  
-multi_module option
.libs/libstdc++.6.0.0.dylib-master.o definition of common  
__gnu_cxx::__mt_alloc<__gnu_cxx::demangler::substitution_st>:: 
_S_thread_key (size 4)
.libs/libstdc++.6.0.0.dylib-master.o definition of common  
__gnu_cxx::__mt_alloc<__gnu_cxx::demangler::qualifier<std:: 
allocator<char> > >::_S_thread_key (size 4)
.libs/libstdc++.6.0.0.dylib-master.o definition of common  
__gnu_cxx::__mt_alloc<int>::_S_thread_key (size 4)

Also I without threads, I get this error:
/home/gates/pinskia/src/gnu/gcc/src/objdir.openbsd/gcc/xgcc  
-shared-libgcc  
-B/home/gates/pinskia/src/gnu/gcc/src/objdir.openbsd/gcc/ -nostdinc++  
-L/home/gates/pinskia/src/gnu/gcc/src/objdir.openbsd/i686-unknown- 
openbsd3.1/fpic/libstdc++-v3/src  
-L/home/gates/pinskia/src/gnu/gcc/src/objdir.openbsd/i686-unknown- 
openbsd3.1/fpic/libstdc++-v3/src/.libs  
-B/home/gates/pinskia/openbsd/i686-unknown-openbsd3.1/bin/  
-B/home/gates/pinskia/openbsd/i686-unknown-openbsd3.1/lib/ -isystem  
/home/gates/pinskia/openbsd/i686-unknown-openbsd3.1/include -isystem  
/home/gates/pinskia/openbsd/i686-unknown-openbsd3.1/sys-include -fpic  
-I/home/gates/pinskia/src/gnu/gcc/src/objdir.openbsd/i686-unknown- 
openbsd3.1/fpic/libstdc++-v3/include/i686-unknown-openbsd3.1  
-I/home/gates/pinskia/src/gnu/gcc/src/objdir.openbsd/i686-unknown- 
openbsd3.1/fpic/libstdc++-v3/include  
-I/home/gates/pinskia/src/gnu/gcc/src/libstdc++-v3/libsupc++ -O2 -g -O2  
-g -O2 -fpic -fno-implicit-templates -Wall -W -Wwrite-strings  
-Wcast-qual -fdiagnostics-show-location=once -c  
/home/gates/pinskia/src/gnu/gcc/src/libstdc++-v3/src/allocator.cc   
-fPIC -DPIC -o .libs/allocator.o
/home/gates/pinskia/src/gnu/gcc/src/libstdc++-v3/src/allocator.cc:50:  
error: no member function `_S_get_thread_id' declared in  
`__gnu_cxx::__mt_alloc<char>'
/home/gates/pinskia/src/gnu/gcc/src/libstdc++-v3/src/allocator.cc:53:  
error: no member function `_S_thread_key_destr' declared in  
`__gnu_cxx::__mt_alloc<char>'

The patch which caused them both:


 2004-01-28  Benjamin Kosnik  <bkoz@redhat.com>

+	* include/Makefile.am (bits_headers): Remove allocator_traits.h.
+	* include/Makefile.in: Regenerate.
+	* include/bits/allocator_traits.h: Remove.
+	* include/bits/allocator.h: Remove allocator_traits.h include, and
+	relevant comments.
+	(allocator): Empty base class, inherit from the underlying allocator.
+	* src/allocator-inst.cc: Move __pool_alloc instantiation to...
+	* src/allocator.cc: ...here. New. For the underlying allocators.
+	Add __mt_alloc, __pool_alloc, new_allocator, malloc_allocator bits.
+	* config/linker-map.gnu: Remove __pool_alloc bits.
+	* src/Makefile.am (sources): Add allocator.cc.
+	* src/Makefile.in: Regenerate.
+	* testsuite/20_util/allocator/1.cc: Split second test into...
+	* testsuite/20_util/allocator/8230.cc: ...this.
+	* include/bits/stl_bvector.h (__gnu_norm): Change bit_vector
+	typedef to use std::allocatore. Format.
+	* include/ext/pool_allocator.h: Remove allocator_traits.h include,
+	_Alloc_traits.
+	* include/ext/mt_allocator.h (__gnu_cxx): Qualify
+	__throw_bad_alloc calls. Don't include <memory>.
+	* include/ext/malloc_allocator.h: Remove <memory> include.
+	* include/ext/new_allocator.h (new_allocator): Same.
+	* include/ext/ropeimpl.h (__gnu_cxx): Remove __alloc using
+	declaration. Switch __alloc to _Alloc.
+	* include/ext/hashtable.h: Remove __alloc.
+	* include/backward/alloc.h: Only inject allocator, not
+	implementation details.
+
+	* include/ext/mt_allocator.h: Replace free with delete.