Re: 2 GCC regressions, 1 new, with your patch on 2003-10-19T21:57:41Z.

[Andrew Pinski <pinskia at physics dot uc dot edu>]

This test is still wrong on PPC (both on the mainline and the tree-ssa):
GCC produces:
 _foo:
        cmpwi cr7,r3,0
        beq- cr7,L2
        dummy1
L2:
        dummy2
        beqlr- cr7
        dummy3
        blr
which means that dummy3 is not executed if cr7's "equal to" bit is on.
So counting labels is still wrong.
New way after patch:
/* { dg-final { scan-assembler-times "L" 4 } } */
Old way before patch:
/* { dg-final { scan-assembler "L(:|\\\$0*)?2" } } */

The old way only looks for L2 or L:2 which in this case is right but is 
very fragile as the testcase says.

I want to say we need a way for this test to be not failing on all 
targets (on all branches also which it really passes but current or old 
way fails for it).

Thanks,
Andrew Pinski


On Oct 19, 2003, at 22:42, GCC regression checker wrote:

> With your recent patch, GCC has some regression test failures, which
> used to pass.  There are 1 new failures, and 1
> failures that existed before and after that patch; 0 failures
> have been fixed.
>
> The new failures are:
> native gcc.sum gcc.dg/old-style-asm-1.c
>
> The old failures, which were not fixed or introduced by your patch, 
> are:
> native g77.sum g77.f-torture/execute/labug1.f
>
> For more information, see http://gcc.gnu.org/regtest/.
> <ChangeLog.diff>--
> Geoffrey Keating <geoffk@apple.com>
> (via an automated GCC regression-testing script.)