Re: GCC build failed for native with your patch on 2003-10-06T06:15:01Z.

[Andrew Pinski <pinskia at physics dot uc dot edu>]

Actually the only one needed was referred in last email and not the  
first one.
This patch removes the other erroneous patches:
--- ../../gcc/config/darwin.c	Mon Oct  6 00:51:35 2003
+++  
/Volumes/UFS_Partition/pinskia/src/fsf/gcc-checkin/src/gcc/config/ 
darwin.c	Sun Oct  5 23:33:53 2003
@@ -304,17 +304,17 @@ machopic_non_lazy_ptr_name (const char *
     bufferlen = 2;
     if (name[0] == '*')
       {
-        memcpy (buffer + bufferlen, name+1, namelen-1+1);
+        memcpy (buffer + bufferlen +1, name+1, namelen-1+1);
         bufferlen += namelen-1;
       }
     else
       {
 	buffer[bufferlen] = '_';
-	memcpy (buffer + bufferlen +1, name, namelen+1);
+	memcpy (buffer + bufferlen+1 +1, name, namelen+1);
         bufferlen += namelen;
       }

-    memcpy (buffer + bufferlen, "$non_lazy_ptr",  
strlen("$non_lazy_ptr")+1);
+    memcpy (buffer + bufferlen +1, "$non_lazy_ptr",  
strlen("$non_lazy_ptr")+1);
     bufferlen += strlen("$non_lazy_ptr");
     ptr_name = get_identifier (buffer);

@@ -379,24 +379,24 @@ machopic_stub_name (const char *name)

     if (name[0] == '*')
       {
-	memcpy (buffer + bufferlen, name+1, namelen - 1 +1);
+	memcpy (buffer + bufferlen +1, name+1, namelen - 1 +1);
         bufferlen += namelen - 1;
       }
     else
       {
 	buffer[bufferlen] = '_';
-	memcpy (buffer + bufferlen +1, name, namelen+1);
+	memcpy (buffer + bufferlen+1 +1, name, namelen+1);
         bufferlen += namelen;
       }

     if (needs_quotes)
       {
-        memcpy (buffer + bufferlen, "$stub\"", strlen("$stub\"")+1);
+        memcpy (buffer + bufferlen +1, "$stub\"", strlen("$stub\"")+1);
         bufferlen += strlen("$stub\"");
       }
     else
       {
-        memcpy (buffer + bufferlen, "$stub", strlen("$stub")+1);
+        memcpy (buffer + bufferlen +1, "$stub", strlen("$stub")+1);
         bufferlen += strlen("$stub");
       }
     ptr_name = get_identifier (buffer);

Thanks,
Andrew Pinski


On Oct 5, 2003, at 23:37, Andrew Pinski wrote:

> Lets try this again (one more off by one error):
> Index: config/darwin.c
> ===================================================================
> RCS file: /cvs/gcc/gcc/gcc/config/darwin.c,v
> retrieving revision 1.48
> diff -u -p -r1.48 darwin.c
> --- config/darwin.c     6 Oct 2003 06:11:14 -0000       1.48
> +++ config/darwin.c     6 Oct 2003 06:35:10 -0000
> @@ -391,12 +391,12 @@ machopic_stub_name (const char *name)
>
>      if (needs_quotes)
>        {
> -        memcpy (buffer + bufferlen +1, "$stub\"", strlen("$stub\""));
> +        memcpy (buffer + bufferlen +1, "$stub\"",  
> strlen("$stub\"")+1);
>          bufferlen += strlen("$stub\"");
>        }
>      else
>        {
> -        memcpy (buffer + bufferlen +1, "$stub", strlen("$stub"));
> +        memcpy (buffer + bufferlen +1, "$stub", strlen("$stub")+1);
>          bufferlen += strlen("$stub");
>        }
>      ptr_name = get_identifier (buffer);
>
> Thanks,
> Andrew Pinski
>
>
>
>
> On Oct 5, 2003, at 23:30, GCC regression checker wrote:
>
> > With your recent patch, GCC does not compile on:
> >  native
> > Attached is build output for those targets.
> >
> > The last time the regression tests were run, GCC did not compile  
> > either,
> > so the problem might not be caused by your patch.
> >
> > For more information, see http://gcc.gnu.org/regtest/.
> > <ChangeLog.diff><native-log.txt>--
> > Geoffrey Keating <geoffk@apple.com>
> > (via an automated GCC regression-testing script.)