This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Mark param_max_combine_insns with Optimization keyword.
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Martin Liška <mliska at suse dot cz>
- Cc: gcc-patches at gcc dot gnu dot org, hubicka at ucw dot cz
- Date: Fri, 3 Jan 2020 10:12:06 -0600
- Subject: Re: [PATCH] Mark param_max_combine_insns with Optimization keyword.
- References: <69e2b120-459b-9c7c-76a5-f90402df48a8@suse.cz>
Hi!
On Thu, Jan 02, 2020 at 12:07:27PM +0100, Martin Liška wrote:
> The param is changed here:
>
> /* Restrict the amount of work combine does at -Og while retaining
> most of its useful transforms. */
> if (opts->x_optimize_debug)
> SET_OPTION_IF_UNSET (opts, opts_set, param_max_combine_insns, 2);
>
> and so that it should be per-function. The only usage is in combine RTL
> pass, which is per-function optimization.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>
> Ready to be installed?
Sure. Okay for trunk. Thanks!
> 2020-01-02 Martin Liska <mliska@suse.cz>
>
> PR tree-optimization/92860
> * params.opt: Mart param_max_combine_insns with Optimization
> keyword.
s/mart/mark/
(Btw, does this help -Og at all? If so, shouldn't it be -O1 as well?)
Segher