This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 35/49] analyzer: new file: sm-file.cc
- From: Jeff Law <law at redhat dot com>
- To: David Malcolm <dmalcolm at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Sat, 07 Dec 2019 08:15:34 -0700
- Subject: Re: [PATCH 35/49] analyzer: new file: sm-file.cc
- References: <1573867416-55618-1-git-send-email-dmalcolm@redhat.com> <1573867416-55618-36-git-send-email-dmalcolm@redhat.com>
- Reply-to: law at redhat dot com
On Fri, 2019-11-15 at 20:23 -0500, David Malcolm wrote:
> This patch adds a state machine checker for stdio's FILE stream API.
>
> gcc/ChangeLog:
> * analyzer/sm-file.cc: New file.
I note this seems somewhat incomplete -- which is fine given my
recommendation was to focus on the double-free analyzer. The biggest
question is do we want to include this in the first iteration? Perhaps
as an example that others can flesh out to capture the missing stuff
(like operations on released FD or file pointers?)
The similarities with double-free, use-after-free are significant. But
I hesitate to suggest trying to generaize and merge them at this point.
jeff