This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix ICE with __builtin_stack_save (PR c/90898)
- From: Jeff Law <law at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>, Richard Biener <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 19 Nov 2019 19:33:23 -0700
- Subject: Re: [PATCH] Fix ICE with __builtin_stack_save (PR c/90898)
- References: <20191119235827.GS4650@tucnak>
On 11/19/19 4:58 PM, Jakub Jelinek wrote:
> Hi!
>
> I agree that we shouldn't have made __builtin_stack_{save,restore} public,
> but I'd fear it is too late to remove it now (and replace by internal fn),
> I'd think some code might use it to control when e.g. alloca will be
> released. As the comment on insert_clobber* says, the addition of the
> clobbers is a best effort, we could end up not finding the right spot and
> not adding the CLOBBER in there even without user __builtin_* calls, so
> this patch just removes an unnecessary assertion and just will not find
> __builtin_stack_restore if something weird is seen, such as in the testcase
> storing of the __builtin_stack_save result into memory, or could be
> a cast or whatever else too.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> 2019-11-19 Jakub Jelinek <jakub@redhat.com>
>
> PR c/90898
> * tree-ssa-ccp.c (insert_clobber_before_stack_restore): Remove
> assertion.
> (insert_clobbers_for_var): Fix a typo in function comment.
>
> * gcc.dg/pr90898.c: New test.
OK
jeff