This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] V6, #2 of 17: Minor code reformat

From: Segher Boessenkool <segher at kernel dot crashing dot org>
To: Michael Meissner <meissner at linux dot ibm dot com>, gcc-patches at gcc dot gnu dot org, dje dot gcc at gmail dot com
Date: Tue, 22 Oct 2019 17:38:11 -0500
Subject: Re: [PATCH] V6, #2 of 17: Minor code reformat
References: <20191016125100.GA31255@ibm-toto.the-meissners.org> <20191016133854.GB4483@ibm-toto.the-meissners.org>

Hi!

On Wed, Oct 16, 2019 at 09:38:54AM -0400, Michael Meissner wrote:
> This patch tweaks the code formatting that I noticed in making the previous
> patch for some of the 128-bit mode move instructions.  Originally this was part
> of V5 patch #2, but it has been moved to a separate patch.

> @@ -7792,7 +7795,10 @@ (define_insn_and_split "*movtd_64bit_nod
>    "#"
>    "&& reload_completed"
>    [(pc)]
> -{ rs6000_split_multireg_move (operands[0], operands[1]); DONE; }
> +{
> +  rs6000_split_multireg_move (operands[0], operands[1]);
> +  DONE;}
> +
>    [(set_attr "length" "8,8,8,12,12,8")
>     (set_attr "max_prefixed_insns" "2")
>     (set_attr "num_insns" "2,2,2,3,3,2")])

Newline before the } here, and no empty line after.  Like all the rest ;-)

Okay with that fixed.  Thanks!


Segher

References:
- PowerPC future machine patches, version 6
  - From: Michael Meissner
- [PATCH] V6, #2 of 17: Minor code reformat
  - From: Michael Meissner

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]