This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/2] gcc/riscv: Add a mechanism to remove some calls to _riscv_save_0

From: Andreas Schwab <schwab at linux-m68k dot org>
To: Jim Wilson <jimw at sifive dot com>
Cc: Andrew Burgess <andrew dot burgess at embecosm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Sat, 31 Aug 2019 09:55:57 +0200
Subject: Re: [PATCH 2/2] gcc/riscv: Add a mechanism to remove some calls to _riscv_save_0
References: <cover.1566241794.git.andrew.burgess@embecosm.com> <bbb9338f2c4bdc2f573de3b7f54f81b56bce4d13.1566241797.git.andrew.burgess@embecosm.com> <CAFyWVaadMw4zkfdwdLSCzsBojwA6tReMPHYcUTuNrqcGwvUmrg@mail.gmail.com> <CAFyWVaa6fJvT1aFTQD-BrnB+PGU6kCPCCokegf6LxurHuQ5Dyg@mail.gmail.com> <CAFyWVaYbTsONTL3d_u-BVQ71tMmsDYgXDfp6nyw9GaQb-iAPpw@mail.gmail.com>

On Aug 30 2019, Jim Wilson <jimw@sifive.com> wrote:

> produced shared libraries that failed again, which turned out because
> the save/restore functions use the alternate link register t0/x5 which
> is clobbered by plts, so we can't call them in shared libraries at
> all.

Shouldn't the save/restore functions always be local to the object, thus
never be called through the PLT?

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

References:
- [PATCH 0/2] RISCV: Reduce code size when compiling with -msave-restore
  - From: Andrew Burgess
- [PATCH 2/2] gcc/riscv: Add a mechanism to remove some calls to _riscv_save_0
  - From: Andrew Burgess
- Re: [PATCH 2/2] gcc/riscv: Add a mechanism to remove some calls to _riscv_save_0
  - From: Jim Wilson
- Re: [PATCH 2/2] gcc/riscv: Add a mechanism to remove some calls to _riscv_save_0
  - From: Jim Wilson
- Re: [PATCH 2/2] gcc/riscv: Add a mechanism to remove some calls to _riscv_save_0
  - From: Jim Wilson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]