This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [testsuite, i386] Fix gcc.target/i386/minmax-4.c etc. on 32-bit Solaris/x86
- From: Jeff Law <law at redhat dot com>
- To: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>, gcc-patches at gcc dot gnu dot org
- Cc: Richard Biener <rguenther at suse dot de>, Uros Bizjak <ubizjak at gmail dot com>
- Date: Thu, 22 Aug 2019 10:25:47 -0600
- Subject: Re: [testsuite, i386] Fix gcc.target/i386/minmax-4.c etc. on 32-bit Solaris/x86
- References: <yddzhk1p6t5.fsf@CeBiTec.Uni-Bielefeld.DE>
On 8/22/19 9:18 AM, Rainer Orth wrote:
> The new gcc.target/i386/minmax-4.c etc. testcases currently FAIL on
> 32-bit Solaris/x86:
>
> FAIL: gcc.target/i386/minmax-4.c scan-assembler-times pmaxsd 1
> FAIL: gcc.target/i386/minmax-4.c scan-assembler-times pmaxud 1
> FAIL: gcc.target/i386/minmax-4.c scan-assembler-times pminsd 1
> FAIL: gcc.target/i386/minmax-4.c scan-assembler-times pminud 1
> FAIL: gcc.target/i386/minmax-5.c scan-assembler-times vpmaxsd 1
> FAIL: gcc.target/i386/minmax-5.c scan-assembler-times vpmaxud 1
> FAIL: gcc.target/i386/minmax-5.c scan-assembler-times vpminsd 1
> FAIL: gcc.target/i386/minmax-5.c scan-assembler-times vpminud 1
> FAIL: gcc.target/i386/minmax-6.c scan-assembler pmaxsd
> FAIL: gcc.target/i386/minmax-7.c scan-assembler pminsd
> FAIL: gcc.target/i386/pr91154.c scan-assembler-not cmov
> FAIL: gcc.target/i386/pr91154.c scan-assembler-times paddd 2
> FAIL: gcc.target/i386/pr91154.c scan-assembler-times pmaxsd 2
>
> I'd mentioned this in PRs target/91154 and target/91498 where Uros
> pointed out that 32-bit Solaris/x86 only guarantees 4-byte stack
> alignment, thus STV is disabled.
>
> In line with several other STV tests, adding -mno-stackrealign to the
> options fixes the failures.
>
> Tested with the appropriate runtest invocation on i386-pc-solaris2.11
> and x86_64-pc-linux-gnu.
>
> Ok for mainline?
OK.
Jeff