Re: [PATCH V2 5/8] bpf: make target-supports.exp aware of eBPF

[jose dot marchesi at oracle dot com (Jose E. Marchesi)]

Hi Seguer!  Thanks for reviewing :)
    
    > @@ -538,6 +539,9 @@ proc check_effective_target_stack_size { } {
    >      if [target_info exists gcc,stack_size] {
    >  	return 1
    >      }
    > +    if [istarget bpf-*-*] {
    > +	return 1
    > +    }
    
    You should still set the proper stack size in your board file, so does
    this help you at all?
    
    > @@ -546,7 +550,11 @@ proc check_effective_target_stack_size { } {
    >  proc dg-effective-target-value { effective_target } {
    >      if { "$effective_target" == "stack_size" } {
    >  	if [check_effective_target_stack_size] {
    > -	    return [target_info gcc,stack_size]
    > +	    if [istarget bpf-*-*] {
    > +		return "512"
    > +	    } else {
    > +		return [target_info gcc,stack_size]
    > +	    }
    
    Yeah okay...  Can't you directly override the gcc,stack_size setting,
    instead of doing that in every(?) place it is checked?
    
Yes I agree these things belong to the board configuration files, so I
will remove that ad-hoc logic from the patch.