This is the mail archive of the
mailing list for the GCC project.
Re: Using gcc/ChangeLog instead of gcc/testsuite/ChangeLog?
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>, Richard Biener <rguenther at suse dot de>, gcc-patches at gcc dot gnu dot org, gcc at gcc dot gnu dot org, amodra at gmail dot com, joern dot rennecke at riscy-ip dot com
- Date: Sat, 10 Aug 2019 12:06:29 -0500
- Subject: Re: Using gcc/ChangeLog instead of gcc/testsuite/ChangeLog?
- References: <201908100653.x7A6rjhE015519@ignucius.se.axis.com> <20190810101246.GG2726@tucnak>
On Sat, Aug 10, 2019 at 12:12:46PM +0200, Jakub Jelinek wrote:
> On Sat, Aug 10, 2019 at 08:53:45AM +0200, Hans-Peter Nilsson wrote:
> > Has there been a change of policy so it's a valid option to use
> > gcc/ChangeLog for testsuite changes? I was about to move a
> > semi-randomly spotted misplaced entry, and when checking if
> > there were others, I noticed that there's like tens of them, so
> > I thought better ask.
> Nothing in the policy changed. While we have mklog that helps with the job,
> it is still mostly hand written stuff and people make occassionally
> mistakes, that can happen to anyone. Admittedly some people repeat those
> mistakes often.
It's why I started doing those
things in the changelogs in the patches I send, to remind me what file
to apply what to. It helps :-)
> I ran the gcc/ subdirectory ChangeLogs through following script that doesn't
> seem to have false positives ATM and highlights some common mistakes people
> make and fixed them, see patch below.
Cool, thank you!
> Another common mistake is more than 2 newline characters in sequence.
Git goes as far as not allowing it in a log message (with standard
configurations, with the standard frontend tools). Drives me nuts, I
use it for formatting all the time.