This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 1/2][MIPS] Emit .note.GNU-stack for soft-float linux targets.
- From: Jeff Law <law at redhat dot com>
- To: Dragan Mladjenovic <dmladjenovic at wavecomp dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: Jakub Jelinek <jakub at redhat dot com>, Matthew Fortune <mfortune at gmail dot com>, Joseph Myers <joseph at codesourcery dot com>, "Maciej W . Rozycki" <macro at linux-mips dot org>, Faraz Shahbazker <fshahbazker at wavecomp dot com>
- Date: Fri, 9 Aug 2019 15:31:50 -0600
- Subject: Re: [PATCH 1/2][MIPS] Emit .note.GNU-stack for soft-float linux targets.
- References: <1565001657-5145-1-git-send-email-dmladjenovic@wavecomp.com> <1565002044-5330-1-git-send-email-dmladjenovic@wavecomp.com>
On 8/5/19 4:47 AM, Dragan Mladjenovic wrote:
> From: "Dragan Mladjenovic" <dmladjenovic@wavecomp.com>
>
> gcc/ChangeLog:
>
> 2019-08-05 Dragan Mladjenovic <dmladjenovic@wavecomp.com>
>
> * config/mips/linux.h (NEED_INDICATE_EXEC_STACK): Define to
> TARGET_SOFT_FLOAT.
> * config/mips/mips.c (TARGET_ASM_FILE_END): Define to ...
> (mips_asm_file_end): New function. Delegate to
> file_end_indicate_exec_stack if NEED_INDICATE_EXEC_STACK is true.
> * config/mips/mips.h (NEED_INDICATE_EXEC_STACK): Define to 0.
>
> libgcc/ChangeLog:
>
> 2019-08-05 Dragan Mladjenovic <dmladjenovic@wavecomp.com>
>
> * config/mips/gnustack.h: New file.
> * config/mips/crti.S: Include gnustack.h.
> * config/mips/crtn.S: Likewise.
> * config/mips/mips16.S: Likewise.
> * config/mips/vr4120-div.S: Likewise.
Seems reasonable. What testing has been done for this patch? I don't
doubt it works for the MIPS linux targets, I'm more interested in making
sure it doesn't do the wrong thing for the embedded mips targets.
Do you have write access to the repository?
jeff